Attention is currently required from: Maximilian Brune.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79230?usp=email )
Change subject: [WIP] treewide: indent conditioanls with whitespaces (Makefiles) ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
File Makefile:
https://review.coreboot.org/c/coreboot/+/79230/comment/520e6dc0_90d4c089 : PS1, Line 4: $(error Error: Path to the main directory cannot contain spaces) this one was already indented...
https://review.coreboot.org/c/coreboot/+/79230/comment/77c76a54_f9ed1566 : PS1, Line 154: printall real-all and this is the issue I was talking about with targets. Indenting the target here makes things ever so much more confusing.
https://review.coreboot.org/c/coreboot/+/79230/comment/d44a1c45_212af37c : PS1, Line 162: else and indenting everything in this block just makes things awful. I think this would need to be rewritten before indenting, because this isn't okay. The targets names need to start all the way to the left.