Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32606
Change subject: mb/apple: MacBook Air 4,2 uses eDP ......................................................................
mb/apple: MacBook Air 4,2 uses eDP
Change-Id: Ifc98eab343fd89b8512e92e01fddf34ef8447d5f Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/32606/1
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 82f120a..4b2ee8f 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -12,7 +12,7 @@ select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_BD82X6X select SYSTEM_TYPE_LAPTOP - select GFX_GMA_INTERNAL_IS_LVDS + select GFX_GMA_INTERNAL_IS_EDP select MAINBOARD_HAS_LIBGFXINIT
config MAINBOARD_DIR
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple: MacBook Air 4,2 uses eDP ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32606/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32606/1//COMMIT_MSG@7 PS1, Line 7: mb/apple: MacBook Air 4,2 uses eDP mb/apple/macbookair4_2: Correct internal video port selection
The MacBook Air 4,2 uses eDP, according to the schematics for A1XXX
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32606
to look at the new patch set (#2).
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
mb/apple/macbookair4_2: Correct internal video port selection
The MacBook Air 4,2 uses eDP, according to the schematics.
Change-Id: Ifc98eab343fd89b8512e92e01fddf34ef8447d5f Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/32606/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
Patch Set 2:
See CB:11842 for further confirmation
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32606/2/src/mainboard/apple/macbookair4_2/Kc... File src/mainboard/apple/macbookair4_2/Kconfig:
https://review.coreboot.org/#/c/32606/2/src/mainboard/apple/macbookair4_2/Kc... PS2, Line 15: select GFX_GMA_INTERNAL_IS_EDP Actually, this is the default. So you could also remove this line.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32606 )
Change subject: mb/apple/macbookair4_2: Correct internal video port selection ......................................................................
mb/apple/macbookair4_2: Correct internal video port selection
The MacBook Air 4,2 uses eDP, according to the schematics.
Change-Id: Ifc98eab343fd89b8512e92e01fddf34ef8447d5f Signed-off-by: Evgeny Zinoviev me@ch1p.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/32606 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/apple/macbookair4_2/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 82f120a..4b2ee8f 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -12,7 +12,7 @@ select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_BD82X6X select SYSTEM_TYPE_LAPTOP - select GFX_GMA_INTERNAL_IS_LVDS + select GFX_GMA_INTERNAL_IS_EDP select MAINBOARD_HAS_LIBGFXINIT
config MAINBOARD_DIR
-
Angel Pons (Code Review) -
Evgeny Zinoviev (Code Review)
-
Felix Held (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)