Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/27148
Change subject: mb/google/poppy/variant/nautilus: Clear GPP_D0 when entering S5 ......................................................................
mb/google/poppy/variant/nautilus: Clear GPP_D0 when entering S5
Nautilus 2nd SKU has a leakage voltage at GPP_D0 in S5 state. We need to set this to LOW when entering S5 for clear the leakage.
BUG=None BRANCH=poppy TEST=Verified the leakage is gone after update coreboot
Change-Id: I054e707b2bc2e63d6f99cd2fd8a57be20615f111 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/poppy/variants/nautilus/Makefile.inc A src/mainboard/google/poppy/variants/nautilus/smihandler.c 2 files changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/27148/1
diff --git a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc index 2167282..dba5ca6 100644 --- a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc @@ -10,3 +10,5 @@ ramstage-y += gpio.c ramstage-y += nhlt.c ramstage-y += mainboard.c + +smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c diff --git a/src/mainboard/google/poppy/variants/nautilus/smihandler.c b/src/mainboard/google/poppy/variants/nautilus/smihandler.c new file mode 100644 index 0000000..0a05064 --- /dev/null +++ b/src/mainboard/google/poppy/variants/nautilus/smihandler.c @@ -0,0 +1,28 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/acpi.h> +#include <baseboard/variants.h> +#include "gpio.h" + +#define LTE3_PWROFF_L GPP_D0 + +void variant_smi_sleep(u8 slp_typ) +{ + if (slp_typ == ACPI_S5) { + /* Turn off LTE module */ + gpio_set(LTE3_PWROFF_L, 0); + } +}