Attention is currently required from: Bao Zheng, Martin Roth, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78274?usp=email )
Change subject: amdfwtool: Set the table size for L1 separately ......................................................................
Patch Set 11:
(3 comments)
Patchset:
PS11: i'd put the TABLE_ALIGNMENT changes in the new_*_dir functions in one patch and the fill_dir_header change into another patch. haven't really understood the fill_dir_header change part of this patch yet, so maybe that's just why i see that as two separate things
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/78274/comment/b82eeca7_a54c75d4 : PS11, Line 615: 1 this should probably be changed to TABLE_ALIGNMENT too. that would allow to drop the adjust_current_pointer(&ctx, 0, 0x1000U); right after psp_combo_dir = new_combo_dir(&ctx);
https://review.coreboot.org/c/coreboot/+/78274/comment/31b8d86c_7dcc7efa : PS11, Line 1221: 1 this should probably also be changed to TABLE_ALIGNMENT