Attention is currently required from: Tim Crawford, Jeremy Soller, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65301 )
Change subject: mb/system76/adl-p: Add Darter Pro 8
......................................................................
Patch Set 14: Code-Review+1
(2 comments)
File src/mainboard/system76/adl-p/Kconfig:
https://review.coreboot.org/c/coreboot/+/65301/comment/78fef033_0e6a14b5
PS14, Line 25: TPM_MEASURED_BOOT
Why is this selected? This option has a prompt, it'd be best to make it default to `y` instead.
File src/mainboard/system76/adl-p/ramstage.c:
https://review.coreboot.org/c/coreboot/+/65301/comment/c5c264e6_5171c348
PS14, Line 25: params->SataPortsSolidStateDrive[1] = 1;
What does this do?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc84d6cc3aec7149d9b538305288bbe2b56d53e4
Gerrit-Change-Number: 65301
Gerrit-PatchSet: 14
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 02 Nov 2022 14:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment