Change in coreboot[master]: soc/amd/common/espi: Don't set alert pin in espi_set_initial_config

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52953 )

Change subject: soc/amd/common/espi: Don't set alert pin in espi_set_initial_config
......................................................................

soc/amd/common/espi: Don't set alert pin in espi_set_initial_config

The eSPI spec says that the Alert Mode defaults to in-band on reset.
This change ensures the controller is in sync with the eSPI peripheral.

The configured alert mode is configured in
espi_set_general_configuration.

BUG=b:187122344, b:186135022
TEST=Boot guybrush and make sure we don't get any eSPI errors.

Signed-off-by: Raul E Rangel 
Change-Id: Ib43e190d08d77ecfcd22ead2bf42e5de2202b555
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52953
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Rob Barnes 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/common/block/lpc/espi_util.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c
index ade1aaa..519130a6 100644
--- a/src/soc/amd/common/block/lpc/espi_util.c
+++ b/src/soc/amd/common/block/lpc/espi_util.c
@@ -864,9 +864,6 @@
 {
    uint32_t espi_initial_mode = ESPI_OP_FREQ_16_MHZ | ESPI_IO_MODE_SINGLE;

-	if (mb_cfg->dedicated_alert_pin)
-		espi_initial_mode |= ESPI_ALERT_MODE;
-
    espi_write32(ESPI_SLAVE0_CONFIG, espi_initial_mode);
 }