Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57316 )
Change subject: mb/google/guybrush: If not using PCIe WWAN, disable the port ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/guybrush/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/57316/comment/f2787b7f_3716c324 PS1, Line 10: const Do we need it to be const? I believe our intention is to prevent the caller(i.e. FSP) from modifying this descriptor. If so we have achieved that with the "const fsp_dxio_descriptor **dxio" in/out parameter.
If we remove const, then we can have one table and fill the WWAN descriptor if variant has PCIe WWAN or reset it if variant does not have PCIe WWAN. Finally return the updated dxio_descriptor. Thoughts?
https://review.coreboot.org/c/coreboot/+/57316/comment/5c4bfc86_b66c4473 PS1, Line 157: }; Nit: If you still prefer the double table approach, then please add a blank line.
https://review.coreboot.org/c/coreboot/+/57316/comment/c8e467f7_3e5e65d0 PS1, Line 191: if (variant_has_pcie_wwan()){
space required before the open brace '{'
Please fix.