Attention is currently required from: Raul Rangel, Martin Roth, Felix Held.
3 comments:
File src/mainboard/google/guybrush/port_descriptors.c:
Patch Set #1, Line 10: const
Do we need it to be const? I believe our intention is to prevent the caller(i.e. FSP) from modifying this descriptor. If so we have achieved that with the "const fsp_dxio_descriptor **dxio" in/out parameter.
If we remove const, then we can have one table and fill the WWAN descriptor if variant has PCIe WWAN or reset it if variant does not have PCIe WWAN. Finally return the updated dxio_descriptor. Thoughts?
Nit: If you still prefer the double table approach, then please add a blank line.
Patch Set #1, Line 191: if (variant_has_pcie_wwan()){
space required before the open brace '{'
Please fix.
To view, visit change 57316. To unsubscribe, or for help writing mail filters, visit settings.