Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
soc/amd/common: Add missing stdint.h to lpc.h
Change-Id: If33765b6dc4236c4b38860bfc4f2cef9b226b81d Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/lpc.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/35269/1
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index ab913b2..6b6745d 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -17,6 +17,7 @@ #define __AMDBLOCKS_LPC_H__
#include <types.h> +#include <stdint.h>
/* PCI registers for D14F3 */ #define LPC_PCI_CONTROL 0x40
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35269/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35269/1//COMMIT_MSG@8 PS1, Line 8: please add why it's needed.
Hello Richard Spiegel, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35269
to look at the new patch set (#2).
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
soc/amd/common: Add missing stdint.h to lpc.h
Include the file containing the typedefs for uint_*.
Change-Id: If33765b6dc4236c4b38860bfc4f2cef9b226b81d Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/lpc.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/35269/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35269/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35269/1//COMMIT_MSG@8 PS1, Line 8:
please add why it's needed.
Done
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
Patch Set 2: Code-Review+2
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35269/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/35269/2/src/soc/amd/common/block/in... PS2, Line 20: #include <stdint.h> types.h already include stdint.h
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35269/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/35269/2/src/soc/amd/common/block/in... PS2, Line 20: #include <stdint.h>
types.h already include stdint. […]
AFAIK we try to overtly add includes to files using a definition, typedef, etc. vs. relying on them being layered.
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
Patch Set 2: Code-Review+1
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h ......................................................................
soc/amd/common: Add missing stdint.h to lpc.h
Include the file containing the typedefs for uint_*.
Change-Id: If33765b6dc4236c4b38860bfc4f2cef9b226b81d Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35269 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/soc/amd/common/block/include/amdblocks/lpc.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Richard Spiegel: Looks good to me, approved Name of user not set #1002476: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index ab913b2..6b6745d 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -17,6 +17,7 @@ #define __AMDBLOCKS_LPC_H__
#include <types.h> +#include <stdint.h>
/* PCI registers for D14F3 */ #define LPC_PCI_CONTROL 0x40
-
Marshall Dawson (Code Review) -
Martin Roth (Code Review)
-
Name of user not set (Code Review)
-
Richard Spiegel (Code Review)