Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, ot_song fan.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85841?usp=email )
Change subject: soc/mediatek/mt8196: Add clk_buf drivers ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85841/comment/dcea7172_e60840fe?usp... : PS4, Line 9: use uses
File src/soc/mediatek/mt8196/clkbuf_ctl.c:
https://review.coreboot.org/c/coreboot/+/85841/comment/ee823840_6d9c1c50?usp... : PS1, Line 228: \n
This newline is for last loop of #226.
Acknowledged
File src/soc/mediatek/mt8196/clkbuf_ctl.c:
https://review.coreboot.org/c/coreboot/+/85841/comment/e9a00369_7240661b?usp... : PS4, Line 27: /* Porting starting from here */ What does this mean? Can we remove the comment?
https://review.coreboot.org/c/coreboot/+/85841/comment/6bdf875f_a4a25bd8?usp... : PS4, Line 156: } Add `,`
https://review.coreboot.org/c/coreboot/+/85841/comment/7132e335_40e7dff2?usp... : PS4, Line 347: = 0 remove
https://review.coreboot.org/c/coreboot/+/85841/comment/355aab87_b79655dc?usp... : PS4, Line 354: __func__, sel, val); Move to previous line.