[S] Change in coreboot[main]: soc/intel/cannonlake: Let coreboot lock MSR_IA32_DEBUG_INTERFACE

[Filip Lewiński (Code Review)]

Attention is currently required from: Felix Singer, Intel coreboot Reviewers, Jérémy Compostella, Krystian Hebel, Martin Roth, Michał Kopeć, Michał Żygowski, Paul Menzel.

Filip Lewiński has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83730?usp=email )

Change subject: soc/intel/cannonlake: Let coreboot lock MSR_IA32_DEBUG_INTERFACE
......................................................................

Patch Set 7:

(4 comments)

File src/include/cpu/intel/msr.h:

https://review.coreboot.org/c/coreboot/+/83730/comment/3318ffab_ff4c9d7d?usp... :
PS6, Line 19: #define MSR_IA32_DEBUG_INTERFACE		0xc80
> It seems to be an extra tab […]

[Done](https://review.coreboot.org/c/coreboot/+/83730/6..7/src/include/cpu/intel/ms...)

File src/soc/intel/cannonlake/lockdown.c:

https://review.coreboot.org/c/coreboot/+/83730/comment/10ebfdad_21d25aca?usp... :
PS6, Line 11: #define   MSR_IA32_DEBUG_INTERFACE_EN		(1 << 0)
            : #define   MS
> Shouldn't it be in src/include/cpu/intel/msr.h ? […]

I've [moved](https://review.coreboot.org/c/coreboot/+/83730/6..7/src/include/cpu/intel/ms...) them to `msr.h`. From what I can see, none of the defines there use the BIT() macro. Should we be consistent with the rest of the file, or would you like me to update all of them?

https://review.coreboot.org/c/coreboot/+/83730/comment/7f43187a_a0e226fb?usp... :
PS6, Line 14: static void cpu_lockdown_cfg(void)
> Could it be called `lock_debug_interface` instead ?

[Done](https://review.coreboot.org/c/coreboot/+/83730/6..7/src/soc/intel/cannonlake...)

https://review.coreboot.org/c/coreboot/+/83730/comment/621e54ce_468563cc?usp... :
PS6, Line 18: 	if (!(msr.lo & MSR_IA32_DEBUG_INTERFACE_LOCK)) {
>

[Done](https://review.coreboot.org/c/coreboot/+/83730/6..7/src/soc/intel/cannonlake...)