Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69710 )
Change subject: build: List all Kconfigs in CBFS `config` file, compress it
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
The intention was that you can do everything with this new file that you could do with the old
Technically, the new use case was already possible, just needed additional steps.
So it's a matter of convenience. We can't have the same convenience for all use
cases with a single solution, AFAICT.
Originally, if one wanted to grep for a config, one had to run `make olddefconfig`
first.
With the fixed, new solution, if one wants to see which options differ
from defaults (a common case when providing user support), one has to run
`make olddefconfig && make savedefconfig`.
I guess there'll always be a use case that isn't easy. That could be mitigated
with a script maybe?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5259ec6f932cdc5780b8843f46dd476da9d19728
Gerrit-Change-Number: 69710
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Comment-Date: Wed, 30 Nov 2022 09:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment