Attention is currently required from: Caveh Jalali, Julius Werner, Arthur Heymans, Boris Mittelberg.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69742 )
Change subject: ec/google/chromeec: Fix clang warnings ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
the primary instance of this file is in the chromium EC tree. […]
Caveh, coreboot engineers are not responsible for making changes in the chromeEC codebase. That's up to Google. When this file was copied into the coreboot codebase, it became part of coreboot. So long as it doesn't affect the output, think that the code changes are free to go either way, if Google wants to take them.
Arthur, do these changes make any difference to the GCC output, or is it still identical? Maybe mark these changes with a /* coreboot change */ so that they don't get removed the next time the file is updated?
PS3: U
-
Martin L Roth (Code Review)