Attention is currently required from: Lijian Zhao. Hello Lijian Zhao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/50352
to review the following change.
Change subject: acpi: Fix Coverity Scan report ......................................................................
acpi: Fix Coverity Scan report
Fix the issue that return value "r" in line 534 will get overwritten problem.
BUG=CID 1445995 TEST=Build sucessful and boot up in QEMU
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Icf760b142cfecfed7c929c15ad190ac74df027b1 --- M src/arch/x86/acpi_bert_storage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/50352/1
diff --git a/src/arch/x86/acpi_bert_storage.c b/src/arch/x86/acpi_bert_storage.c index ec31917..ef10a6b 100644 --- a/src/arch/x86/acpi_bert_storage.c +++ b/src/arch/x86/acpi_bert_storage.c @@ -534,7 +534,7 @@ r = bert_append_genproc(status); else if (!guidcmp(guid, &CPER_SEC_PROC_GENERIC_GUID)) r = bert_append_ia32x64(status); - if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID)) + else if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID)) r = bert_append_fw_err(status); /* else if other types not implemented */ else