Attention is currently required from: Kapil Porwal, Subrata Banik.
Mac Chiang has posted comments on this change by Mac Chiang. ( https://review.coreboot.org/c/coreboot/+/86699?usp=email )
Change subject: mb/google/fatcat/var/francka: Add support for DMIC0 ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/francka/fw_config.c:
https://review.coreboot.org/c/coreboot/+/86699/comment/eee03abb_3e9aeed0?usp... : PS6, Line 28: /* GPP_D09: PCH_DGPU_HOLD_RST#_R */ : PAD_NC(GPP_D09, NONE), : /* GPP_D16: HDA_RST# */ : PAD_NC(GPP_D16, NONE), : /* GPP_S00: SNDW_3_SCL */ : PAD_NC(GPP_S00, NONE), : /* GPP_S01: SNDW_3_SDA */ : PAD_NC(GPP_S01, NONE), : /* GPP_S04: SNDW2_CLK */ : PAD_NC(GPP_S04, NONE), : /* GPP_S05: SNDW2_DATA0 */ : PAD_NC(GPP_S05, NONE),
These pins are NC in either case. why not move them to gpio. […]
For future SoundWire SKUs, I think it will need to be reconfigured if set to default.