Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32399
Change subject: soc/intel/cannonlake: add missing console.h include ......................................................................
soc/intel/cannonlake: add missing console.h include
Change-Id: Ic23eb57a4096d4301d7f9478d8e65aaeb233de7b Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/soc/intel/cannonlake/acpi.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/32399/1
diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index 43d91d3..19469dc 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -20,6 +20,7 @@ #include <arch/smp/mpspec.h> #include <cbmem.h> #include <chip.h> +#include <console/console.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <ec/google/chromeec/ec.h>
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32399 )
Change subject: soc/intel/cannonlake: add missing console.h include ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has removed a vote on this change.
Change subject: soc/intel/cannonlake: add missing console.h include ......................................................................
Removed Verified-1 by build bot (Jenkins) no-reply@coreboot.org
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32399 )
Change subject: soc/intel/cannonlake: add missing console.h include ......................................................................
Patch Set 1: Verified+1
Overriding the Verified-1 because it is due to the issue fixed in the follow up commit.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32399 )
Change subject: soc/intel/cannonlake: add missing console.h include ......................................................................
soc/intel/cannonlake: add missing console.h include
Change-Id: Ic23eb57a4096d4301d7f9478d8e65aaeb233de7b Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32399 Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/cannonlake/acpi.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Patrick Georgi: Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index 43d91d3..19469dc 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -20,6 +20,7 @@ #include <arch/smp/mpspec.h> #include <cbmem.h> #include <chip.h> +#include <console/console.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <ec/google/chromeec/ec.h>
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review)