Attention is currently required from: Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56044 )
Change subject: [TESTONLY]do we use cbfs-relative base addresses as input??
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I mean, if you remove this there'd be no more way at all to define a specific base for a file on non-x86 images, right? While I'm not aware of any board specifically using that right now it's probably not something we should make entirely impossible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87349e98d6aeac5d3f79c8a067982cd136a0b863
Gerrit-Change-Number: 56044
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 08 Jul 2021 00:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment