Change in ...coreboot[master]: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32886
Change subject: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions ......................................................................
src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions
Probably a copy/past issue.
Change-Id: I0334bc1f5d145df5af0a307cf8e7c23cc0605f76 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/32886/1
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 5efd590..c5c78ca 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -237,9 +237,9 @@
/* Don't show ingredient name and version if its all 0xFF */ if (fvi[index].Version.MajorVersion == 0xFF && - fvi[index].Version.MajorVersion == 0xFF && - fvi[index].Version.MajorVersion == 0xFF && - fvi[index].Version.MajorVersion == 0xFF && + fvi[index].Version.MinorVersion == 0xFF && + fvi[index].Version.Revision == 0xFF && + fvi[index].Version.BuildNumber == 0xFF && fvi[index].VersionStringIndex == 0) { str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t));
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32886 )
Change subject: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32886/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32886/1//COMMIT_MSG@9 PS1, Line 9: past paste
Hello Patrick Rudolph, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32886
to look at the new patch set (#2).
Change subject: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions ......................................................................
src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions
Probably a copy/paste issue.
Change-Id: I0334bc1f5d145df5af0a307cf8e7c23cc0605f76 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/32886/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32886 )
Change subject: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32886/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32886/1//COMMIT_MSG@9 PS1, Line 9: past
paste
Donne. Thx
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32886 )
Change subject: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions ......................................................................
Patch Set 2:
(1 comment)
Done* :)
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32886 )
Change subject: src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions ......................................................................
src/drivers/intel/fsp2_0: Fix logical 'and' of equal expressions
Probably a copy/paste issue.
Change-Id: I0334bc1f5d145df5af0a307cf8e7c23cc0605f76 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32886 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 5efd590..c5c78ca 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -237,9 +237,9 @@
/* Don't show ingredient name and version if its all 0xFF */ if (fvi[index].Version.MajorVersion == 0xFF && - fvi[index].Version.MajorVersion == 0xFF && - fvi[index].Version.MajorVersion == 0xFF && - fvi[index].Version.MajorVersion == 0xFF && + fvi[index].Version.MinorVersion == 0xFF && + fvi[index].Version.Revision == 0xFF && + fvi[index].Version.BuildNumber == 0xFF && fvi[index].VersionStringIndex == 0) { str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t));
-
Furquan Shaikh (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)