Attention is currently required from: Arthur Heymans, Felix Singer, Filip Lewiński, Krystian Hebel, Martin Roth, Michał Kopeć, Yu-Ping Wu.
Julius Werner has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82417?usp=email )
Change subject: security/intel/txt: Verify Intel TXT required TPM2 indices presence
......................................................................
Patch Set 21:
(1 comment)
File src/security/intel/txt/common.c:
https://review.coreboot.org/c/coreboot/+/82417/comment/bff28d16_cd0369fd?usp... :
PS21, Line 627: #if CONFIG(TPM2)
You can put this in a C `if()`, you don't need to use a preprocessor guard. It will compile out the code if that Kconfig is disabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82417?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5b4267b2d51e21cfa514e96301f30ebf7437c470
Gerrit-Change-Number: 82417
Gerrit-PatchSet: 21
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 01 Apr 2025 23:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No