Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85878?usp=email )
Change subject: soc/mediatek/common: Get storage type from mainboard
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/include/soc/storage.h:
https://review.coreboot.org/c/coreboot/+/85878/comment/42fcba7f_79753672?usp... :
PS2, Line 11: 0x0
Just noticed that `_BASE_TYPE(x)` would return UFS for `STORAGE_UNKNOWN`. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85878?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dba2b54b29a701b825fb9bfcac74eb45a563d71
Gerrit-Change-Number: 85878
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 08 Jan 2025 02:51:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com