Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/48866 )
Change subject: em100: Make trace mode output more resilient ......................................................................
em100: Make trace mode output more resilient
When redirecting em100 output to a file, say with | tee <filename>, we won't see any output from the tool until actual SPI commands are coming in. This is annoying, as you don't know when the download is finished, if your workflow is for example as follows:
1. start em100 in trace mode 2. wait for download to em100 to finish 3. power-cycle / turn on the machine
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I36916ab71d3b929deb4d8cfed7b22a2ce90b2672 --- M em100.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/66/48866/1
diff --git a/em100.c b/em100.c index d7afc34..0317565 100644 --- a/em100.c +++ b/em100.c @@ -1260,7 +1260,8 @@ printf("terminal"); }
- printf(". Press CTL-C to exit.\n\n"); + printf(". Press CTRL-C to exit.\n\n"); + fflush(stdout);
while (!exit_requested && usb_errors < MAX_USB_ERRORS) { int ret;
Attention is currently required from: Stefan Reinauer. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48866 )
Change subject: em100: Make trace mode output more resilient ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48866 )
Change subject: em100: Make trace mode output more resilient ......................................................................
Patch Set 1: Code-Review+1
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/48866 )
Change subject: em100: Make trace mode output more resilient ......................................................................
em100: Make trace mode output more resilient
When redirecting em100 output to a file, say with | tee <filename>, we won't see any output from the tool until actual SPI commands are coming in. This is annoying, as you don't know when the download is finished, if your workflow is for example as follows:
1. start em100 in trace mode 2. wait for download to em100 to finish 3. power-cycle / turn on the machine
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I36916ab71d3b929deb4d8cfed7b22a2ce90b2672 Reviewed-on: https://review.coreboot.org/c/em100/+/48866 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M em100.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/em100.c b/em100.c index 7a6f910..a8a0708 100644 --- a/em100.c +++ b/em100.c @@ -1246,7 +1246,8 @@ printf("terminal"); }
- printf(". Press CTL-C to exit.\n\n"); + printf(". Press CTRL-C to exit.\n\n"); + fflush(stdout);
while (!exit_requested && usb_errors < MAX_USB_ERRORS) { int ret;
-
Angel Pons (Code Review) -
Stefan Reinauer (Code Review)
-
Tim Wawrzynczak (Code Review)