Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62779 )
Change subject: mb/google/brya: Remove mainboard.asl
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/62779/comment/78827543_1442321c
PS3, Line 115: acpigen_write_if_lequal_op_int(ARG0_OP, 1);
: if (CONFIG(HAVE_SLP_S0_GATE))
: acpigen_soc_clear_tx_gpio(GPIO_SLP_S0_GATE);
: variant_generate_s0ix_hook(S0IX_ENTRY);
: acpigen_write_else();
: if (CONFIG(HAVE_SLP_S0_GATE))
: acpigen_soc_set_tx_gpio(GPIO_SLP_S0_GATE);
: variant_generate_s0ix_hook(S0IX_EXIT);
: acpigen_write_if_end();
suggestion (adding {} only) […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic36543e5cbaf8aaa7d933dcf54badc5f40e8ef02
Gerrit-Change-Number: 62779
Gerrit-PatchSet: 4
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Comment-Date: Tue, 15 Mar 2022 00:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment