Attention is currently required from: Furquan Shaikh, Martin Roth, Meera Ravindranath, Aamir Bohra, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49474 )
Change subject: drivers/intel/fsp2_0: Add support for MP services2 PPI
......................................................................
Patch Set 8:
(3 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/49474/comment/0e41f421_004d225d
PS6, Line 267:
: if FSP_PEIM_TO_PEIM_INTERFACE
: source "src/drivers/intel/fsp2_0/ppi/Kconfig"
: endif
:
This gets sourced from src/Makefile. […]
It's redundant, src/Kconfig already has `source "src/drivers/*/*/*/Kconfig`
File src/drivers/intel/fsp2_0/include/fsp/ppi/mp_service_ppi.h:
https://review.coreboot.org/c/coreboot/+/49474/comment/76689570_0a115e84
PS6, Line 49: /*
: * switches the requested AP to be the BSP
: */
: efi_return_status_t mp_switch_bsp(void);
:
: /*
: * enable or disable an AP. This service may only be called from the BSP.
: */
: efi_return_status_t mp_enable_disable_ap(void);
:
we can keep them as placeholders for now? Is it ok?
We could just have a `efi_return_status_t fsp_ppi_unsupported(void) { return FSP_UNSUPPORTED; }` as an example and use that function pointer instead
File src/drivers/intel/fsp2_0/ppi/mp_service1.c:
https://review.coreboot.org/c/coreboot/+/49474/comment/69cc8a09_81ef060f
PS6, Line 12:
nit: extra lines
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id74baf17fb90147d229c78be90268fdc3ec1badc
Gerrit-Change-Number: 49474
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Feb 2021 16:00:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment