Attention is currently required from: Arthur Heymans, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )
Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status
......................................................................
Patch Set 15:
(1 comment)
File src/drivers/net/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/7b05b884_fef0fbc3
PS14, Line 18: page_reg
Is this still the 'page_reg'? This name can lead to confusions with the real PAGE_REG. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904
Gerrit-Change-Number: 69386
Gerrit-PatchSet: 15
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 21 Nov 2022 08:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment