Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45952/22//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45952/22//COMMIT_MSG@13
PS22, Line 13: Also, make the TCO SMI option select ACPI PM timer, since TCO won't work
: without it.
this turns out to be wrong. I assumed that TCO depends on the hardware PM timer because I wasn't able to trigger a TCO SMI (tested by triggering the intruder). However, I did more tests today and finally found the reason why that SMI wasn't triggered: there's a bug in Linux leading to a soft-lockup when a TCO SMI gets triggered. It works fine before Linux starts.
I'll drop that dependeny and adapt the help texts...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f607f277eb14f84a7370ffb25a13226e7ccc917
Gerrit-Change-Number: 45952
Gerrit-PatchSet: 22
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Oct 2020 23:28:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment