Attention is currently required from: V Sowmya, Martin Roth, Sugnan Prabhu S, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/intel/shadowmountain/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49479/comment/82f7acef_dc31f8ef
PS2, Line 7:
: romstage-$(CONFIG_CHROMEOS) += chromeos.c
:
: ramstage-$(CONFIG_CHROMEOS) += chromeos.c
:
later with ramstage/romstage phase?
File src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/49479/comment/6881bf3d_0c65f22c
PS2, Line 8: early_gpio_table
Need to add memstrap gpios, TPM Gpios
File src/mainboard/intel/shadowmountain/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/49479/comment/52610ce2_af967cf3
PS2, Line 13: GPP_B11
chromeos.c marked it as todo?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 10:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment