HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46159 )
Change subject: mb/asus/p2b: Convert to ASL 2.0 syntax ......................................................................
mb/asus/p2b: Convert to ASL 2.0 syntax
Change-Id: Ib07e4147f7f1b90f721be147d48ed12ae793c4fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/46159/1
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index e1bda17..ef9a4a8 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -59,23 +59,23 @@ Method (_PTS, 1, NotSerialized) { /* Disable fan, blink power LED, if not turning off */ - If (LNotEqual (Arg0, 0x05)) + If (Arg0 != 0x05) { - Store (Zero, FANM) - Store (Zero, PLED) + FANM = 0 + PLED = 0 }
/* Arms SMI for device 12 */ - Store (One, TO12) + TO12 = 1 /* Put out a POST code */ - Or (Arg0, 0xF0, P80) + P80 = Arg0 | 0xF0 }
Method (_WAK, 1, NotSerialized) { /* Re-enable fan, stop power led blinking */ - Store (One, FANM) - Store (One, PLED) + FANM = 1 + PLED = 1 /* wake OK */ Return(Package(0x02){0x00, 0x00}) } @@ -204,10 +204,10 @@ CreateWordField (BUF1, _Y07._MIN, SBLO) CreateWordField (BUF1, _Y07._MAX, SBRL)
- And (_SB.PCI0.PX43.PM00, 0xFFFE, PMLO) - And (_SB.PCI0.PX43.SB00, 0xFFFE, SBLO) - Store (PMLO, PMRL) - Store (SBLO, SBRL) + PMLO = _SB.PCI0.PX43.PM00 & 0xFFFE + SBLO = _SB.PCI0.PX43.SB00 & 0xFFFE + PMRL = PMLO + SBRL = SBLO Return (BUF1) } } @@ -238,13 +238,13 @@ { Method (_MSG, 1, NotSerialized) { - If (LEqual (Arg0, Zero)) + If (Arg0 == 0) { - Store (One, MSG0) + MSG0 = 1 } Else { - Store (Zero, MSG0) + MSG0 = 0 } } }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46159
to look at the new patch set (#2).
Change subject: mb/asus/p2b: Convert to ASL 2.0 syntax ......................................................................
mb/asus/p2b: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: Ib07e4147f7f1b90f721be147d48ed12ae793c4fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/46159/2
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46159 )
Change subject: mb/asus/p2b: Convert to ASL 2.0 syntax ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46159 )
Change subject: mb/asus/p2b: Convert to ASL 2.0 syntax ......................................................................
mb/asus/p2b: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: Ib07e4147f7f1b90f721be147d48ed12ae793c4fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46159 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 14 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index 384f8de..006db8a 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -67,23 +67,23 @@ Method (_PTS, 1, NotSerialized) { /* Disable fan, blink power LED, if not turning off */ - If (LNotEqual (Arg0, 0x05)) + If (Arg0 != 0x05) { - Store (Zero, FANM) - Store (Zero, PLED) + FANM = 0 + PLED = 0 }
/* Arms SMI for device 12 */ - Store (One, TO12) + TO12 = 1 /* Put out a POST code */ - Or (Arg0, 0xF0, P80) + P80 = Arg0 | 0xF0 }
Method (_WAK, 1, NotSerialized) { /* Re-enable fan, stop power led blinking */ - Store (One, FANM) - Store (One, PLED) + FANM = 1 + PLED = 1 /* wake OK */ Return(Package(0x02){0x00, 0x00}) } @@ -212,10 +212,10 @@ CreateWordField (BUF1, _Y07._MIN, SBLO) CreateWordField (BUF1, _Y07._MAX, SBRL)
- And (_SB.PCI0.PX43.PM00, 0xFFFE, PMLO) - And (_SB.PCI0.PX43.SB00, 0xFFFE, SBLO) - Store (PMLO, PMRL) - Store (SBLO, SBRL) + PMLO = _SB.PCI0.PX43.PM00 & 0xFFFE + SBLO = _SB.PCI0.PX43.SB00 & 0xFFFE + PMRL = PMLO + SBRL = SBLO Return (BUF1) } } @@ -246,13 +246,13 @@ { Method (_MSG, 1, NotSerialized) { - If (LEqual (Arg0, Zero)) + If (Arg0 == 0) { - Store (One, MSG0) + MSG0 = 1 } Else { - Store (Zero, MSG0) + MSG0 = 0 } } }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)