Attention is currently required from: Bhanu Prakash Maiya, Kenneth Chan, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 )
Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60442/comment/86ea3cb6_9d986ac0
PS4, Line 11: 1019 id changed to 10EC1019:0/10EC1019:1 from 10EC1019:1/10EC1019:2.
New id is 10EC1019:1/10EC1019:2 right? So 10EC1019:1/10EC1019:2 from 10EC1019:0/10EC1019:1?
File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60442/comment/e9acd419_4a1f4fd3
PS4, Line 151: register "uid" = "1"
"probed" = "1"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I542f886fe63205777837d7146169177b043cc5f2
Gerrit-Change-Number: 60442
Gerrit-PatchSet: 4
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 30 Dec 2021 03:33:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment