Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55330 )
Change subject: soc/intel/tigerlake: Make use of is_devfn_enabled() function
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55330/comment/68ea40d1_0d271f2c
PS6, Line 260: /* Enable xDCI controller if enabled in devicetree and allowed */
: dev = pcidev_path_on_root(PCH_DEVFN_USBOTG);
: if (dev) {
: if (!xdci_can_enable())
: dev->enabled = 0;
: params->XdciEnable = dev->enabled;
: } else {
: params->XdciEnable = 0;
: }
Tim, as i have posted in ADL CL, can we take removal of dev->enabled using https://review.coreboot. […]
Marking this also ACK, as same implementation as ADL and other SOC. Tim, please let me know if you see otherwise?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d91b711bab83de1911e0b7ea876f2ad018c937
Gerrit-Change-Number: 55330
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 15 Jun 2021 05:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment