Attention is currently required from: Tarun Tuli, Paul Menzel.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69286 )
Change subject: soc/intel/alderlake: Update ME HFSTS register definition
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69286/comment/26bd84b3_77545414
PS1, Line 7: aldrlake
alderlake
Done
https://review.coreboot.org/c/coreboot/+/69286/comment/51fdabd8_c31cef7a
PS1, Line 9: AlderLake
Alder Lake
Done
https://review.coreboot.org/c/coreboot/+/69286/comment/43e7b9bf_13dfd685
PS1, Line 11:
What problem does this fix?
The definitions were copied from previous platforms, which have changed. Follow CLs needed the correct definitions to perform some checks
https://review.coreboot.org/c/coreboot/+/69286/comment/92c4e185_35d8a554
PS1, Line 12: Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com
Could you add details on what testing you did with the updated definition?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9aeee7a3b41ad59c03391207930a253ffff19ae5
Gerrit-Change-Number: 69286
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 08 Nov 2022 20:07:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment