Change in ...libgfxinit[master]: gma config: Make Config.CPU and Config.CPU_Var variable - coreboot-gerrit

6 May 2019


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27068 )
Change subject: gma config: Make Config.CPU and Config.CPU_Var variable
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/27068/7/common/Makefile.inc 
File common/Makefile.inc:
https://review.coreboot.org/#/c/27068/7/common/Makefile.inc@64 
PS7, Line 64: _GEN_CONST_TARGET := <cpufunc> # set to `constant` to generate constants.
that's positively crazy :-)
-- 
To view, visit https://review.coreboot.org/c/libgfxinit/+/27068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: If409b5afbd975f3a42e28ff191a092f89ece5ae2
Gerrit-Change-Number: 27068
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Adrian-Ken Rueegsegger ken@codelabs.ch
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Reto Buerki reet@codelabs.ch
Gerrit-Comment-Date: Mon, 06 May 2019 19:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment