Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28076 )
Change subject: mb/google/poppy/variants/nocturne: remove dup'ed dptf_enable ......................................................................
mb/google/poppy/variants/nocturne: remove dup'ed dptf_enable
This file contains two instances of "dptf_enable" = "1". This change removes the 2nd instance (it doesn't have an explicit comment like the 1st instance).
The dptf devices still seem to be present even with this change, as expected.
Change-Id: I890006644be9176ebaf555cc121c816e12f2b596 Signed-off-by: Matt Delco delco@chromium.org Reviewed-on: https://review.coreboot.org/28076 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 4fbd0ff..88af929 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -61,7 +61,6 @@
# Set speed_shift_enable to 1 to enable P-States, and 0 to disable register "speed_shift_enable" = "1" - register "dptf_enable" = "1" register "tdp_pl2_override" = "18" register "psys_pmax" = "45" register "tcc_offset" = "10"