[S] Change in coreboot[master]: util/cbfstool: Add "Comp" column for "print -k" - coreboot-gerrit

10 Apr 2023


      Attention is currently required from: Julius Werner, Eric Lai.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74317 )
Change subject: util/cbfstool: Add "Comp" column for "print -k"
......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/cbfs_image.c:
https://review.coreboot.org/c/coreboot/+/74317/comment/3619d0c4_2152b2d0 
PS1, Line 1535: 	const char *compression_name = lookup_name_by_type(
...
should we still keep the guard? if(compression != CBFS_COMPRESS_NONE)
No I don't think so, because now "Comp" becomes a default column. Previously the compression type and the hash compose a list which can contain various number of elements.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3e23c58662fb7b9c5d704de93e2df28957528d
Gerrit-Change-Number: 74317
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 09:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment