Change in coreboot[master]: vendorcode/eltan/security/lib: Always enable include cb_sha.c for boo...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Frans Hendriks (Code Review)

2 Aug 2019 2 Aug '19

1:34 p.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always enable include cb_sha.c for bootblock ......................................................................

vendorcode/eltan/security/lib: Always enable include cb_sha.c for bootblock

cb_sha.c depends on C_ENVIRONMENT_BOOTBLOCK. Include cb_sha.c unconditional since C_ENVIRONMENT_BOOTBLOCK is default for projects.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/vendorcode/eltan/security/lib/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34667/1

diff --git a/src/vendorcode/eltan/security/lib/Makefile.inc b/src/vendorcode/eltan/security/lib/Makefile.inc index 5ef1bca..2c98aca 100644 --- a/src/vendorcode/eltan/security/lib/Makefile.inc +++ b/src/vendorcode/eltan/security/lib/Makefile.inc @@ -40,7 +40,7 @@

ifneq ($(filter y,$(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)),)

-bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += cb_sha.c +bootblock-y += cb_sha.c $(eval $(call vendor-security-lib,bootblock)) bootblock-srcs += $(obj)/external/ven_sec_lib-bootblock/vboot_fw21.a

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Frans Hendriks (Code Review)

2 Aug 2 Aug

1:35 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Hello Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34667

to look at the new patch set (#2).

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

cb_sha.c depends on C_ENVIRONMENT_BOOTBLOCK. Include cb_sha.c unconditional since C_ENVIRONMENT_BOOTBLOCK is default for projects.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34667/2

Lance Zhao (Code Review)

5 Aug 5 Aug

2:35 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

Patch Set 2:

Is that necessary? We can't grantee it will never happen in future.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 05 Aug 2019 00:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

13 Aug 13 Aug

1:30 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

Patch Set 2:

The Kconfig: * C_ENVIRONMENT_BOOTBLOCK will be removed in 4.11 (See email 23/7/2019 CB list: [coreboot]Announcing coreboot 4.10)

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Aug 2019 11:30:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Lance Zhao (Code Review)

1:35 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

Patch Set 2:

...

Patch Set 2:

The Kconfig:

C_ENVIRONMENT_BOOTBLOCK

will be removed in 4.11 (See email 23/7/2019 CB list: [coreboot]Announcing coreboot 4.10)

Okay

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Aug 2019 11:35:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Lance Zhao (Code Review)

1:35 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Aug 2019 11:35:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

22 Aug 22 Aug

1:59 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Hello Patrick Rudolph, Felix Held, Julius Werner, Lance Zhao, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34667

to look at the new patch set (#3).

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

cb_sha.c depends on C_ENVIRONMENT_BOOTBLOCK. Include cb_sha.c unconditional since C_ENVIRONMENT_BOOTBLOCK is default for chipsets.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34667/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Frans Hendriks (Code Review)

23 Aug 23 Aug

8:20 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Hello Patrick Rudolph, Felix Held, Julius Werner, Lance Zhao, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34667

to look at the new patch set (#4).

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

cb_sha.c depends on C_ENVIRONMENT_BOOTBLOCK. Include cb_sha.c unconditional since C_ENVIRONMENT_BOOTBLOCK is default for chipsets.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34667/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Frans Hendriks (Code Review)

8:51 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

Patch Set 4:

...

Patch Set 2: Code-Review+2

Have created a new patchset solving the merge conflict.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 23 Aug 2019 06:51:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Lance Zhao (Code Review)

25 Aug 25 Aug

10:57 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 25 Aug 2019 08:57:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Aug 26 Aug

3:46 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34667 )

Change subject: vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock ......................................................................

vendorcode/eltan/security/lib: Always include cb_sha.c for bootblock

cb_sha.c depends on C_ENVIRONMENT_BOOTBLOCK. Include cb_sha.c unconditional since C_ENVIRONMENT_BOOTBLOCK is default for chipsets.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34667 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lance Zhao lance.zhao@gmail.com --- M src/vendorcode/eltan/security/lib/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Lance Zhao: Looks good to me, approved

diff --git a/src/vendorcode/eltan/security/lib/Makefile.inc b/src/vendorcode/eltan/security/lib/Makefile.inc index 1f74759..2e11fb5 100644 --- a/src/vendorcode/eltan/security/lib/Makefile.inc +++ b/src/vendorcode/eltan/security/lib/Makefile.inc @@ -40,7 +40,7 @@

ifneq ($(filter y,$(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)),)

-bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += cb_sha.c +bootblock-y += cb_sha.c bootblock-y += ../../../../security/vboot/vboot_logic.c $(eval $(call vendor-security-lib,bootblock)) bootblock-srcs += $(obj)/external/ven_sec_lib-bootblock/vboot_fw21.a

-- To view, visit https://review.coreboot.org/c/coreboot/+/34667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If93195596efe7d8f298430e67eb1cf79804b96fc Gerrit-Change-Number: 34667 Gerrit-PatchSet: 5 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2073

days inactive

2097

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Frans Hendriks (Code Review)
Lance Zhao (Code Review)
Patrick Georgi (Code Review)