Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81432?usp=email )
Change subject: soc/amd/common/noncar/memmap: reduce visibility of memmap_early_dram ......................................................................
soc/amd/common/noncar/memmap: reduce visibility of memmap_early_dram
The memmap_early_dram struct is now only used inside the non-CAR memmap.c, so move the struct definition there.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Id2bb3d3a9e01e9bae9463c582cb105b95c673a38 --- M src/soc/amd/common/block/cpu/noncar/memmap.c M src/soc/amd/common/block/include/amdblocks/memmap.h 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/81432/1
diff --git a/src/soc/amd/common/block/cpu/noncar/memmap.c b/src/soc/amd/common/block/cpu/noncar/memmap.c index e6db85a..396260f 100644 --- a/src/soc/amd/common/block/cpu/noncar/memmap.c +++ b/src/soc/amd/common/block/cpu/noncar/memmap.c @@ -10,6 +10,12 @@ #include <memrange.h> #include <types.h>
+struct memmap_early_dram { + /* fixed size types, so the layout in CBMEM won't change for 32 vs. 64 bit stages */ + uint32_t base; + uint32_t size; +}; + void memmap_stash_early_dram_usage(void) { struct memmap_early_dram *e; diff --git a/src/soc/amd/common/block/include/amdblocks/memmap.h b/src/soc/amd/common/block/include/amdblocks/memmap.h index 258b8b7..e769df6 100644 --- a/src/soc/amd/common/block/include/amdblocks/memmap.h +++ b/src/soc/amd/common/block/include/amdblocks/memmap.h @@ -9,12 +9,6 @@
DECLARE_REGION(early_reserved_dram)
-struct memmap_early_dram { - /* fixed size types, so the layout in CBMEM won't change for 32 vs. 64 bit stages */ - uint32_t base; - uint32_t size; -}; - void memmap_stash_early_dram_usage(void);
/* report SoC memory map up to cbmem_top */