Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email )
Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80923/comment/aaf86b41_099705a3 :
PS1, Line 101: $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c1-2))) )
Does this still support version number parts that contains more than two digits? […]
OK, I misread the code. Indeed it just takes a 16 bit value (2 bytes) and prints it in decimal. Thanks for the link, looks good to me now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80923?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0165d81b0e4b38e0e097956f250bb7484d774145
Gerrit-Change-Number: 80923
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Sun, 03 Mar 2024 12:14:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment