Julius Werner has posted comments on this change. ( https://review.coreboot.org/19764 )
Change subject: lib/edid: Split out fill_lb_framebuffer() ......................................................................
Patch Set 6: Code-Review+1
Thanks, I'm okay with this as well. (I'm still not quite sure in what situation you think this is better than the weak symbol solution. Are you concerned about hypothetical platforms that could offer both native init and libgfxinit as choices? But then you just hide the source files that prove fill_lb_framebuffer() behind CONFIG_MAINBOARD_USE_LIBGFXINIT and it'll still work fine for either configuration? ...well, okay, as long as I don't have to select an extra option from every single ARM SoC I'm happy with it.)
-
Julius Werner (Code Review)