Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/28195
Change subject: ec/pmh7: use read/write function in clear_bit/set_bit ......................................................................
ec/pmh7: use read/write function in clear_bit/set_bit
Make the code simpler and improve readability.
Change-Id: Ifa9308c32e4646c122254931b55fb83541a10a3c --- M src/ec/lenovo/pmh7/pmh7.c 1 file changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/28195/1
diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c index c975679..b160fd0 100644 --- a/src/ec/lenovo/pmh7/pmh7.c +++ b/src/ec/lenovo/pmh7/pmh7.c @@ -68,20 +68,16 @@ { char val;
- outb(reg, EC_LENOVO_PMH7_ADDR); - val = inb(EC_LENOVO_PMH7_DATA); - outb(reg, EC_LENOVO_PMH7_ADDR); - outb(val | (1 << bit), EC_LENOVO_PMH7_DATA); + val = pmh7_register_read(reg); + pmh7_register_write(reg, val | (1 << bit)); }
void pmh7_register_clear_bit(int reg, int bit) { char val;
- outb(reg, EC_LENOVO_PMH7_ADDR); - val = inb(EC_LENOVO_PMH7_DATA); - outb(reg, EC_LENOVO_PMH7_ADDR); - outb(val &= ~(1 << bit), EC_LENOVO_PMH7_DATA); + val = pmh7_register_read(reg); + pmh7_register_write(reg, val & ~(1 << bit)); }
char pmh7_register_read(int reg)