Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74512 )
Change subject: mb/google/skyrim: Fix eMMC reset GPIO
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74512/comment/492cb62e_c6a2ea22
PS1, Line 9: On Whiterun, the eMMC reset GPIO should be SSD_AUX_RST_L(GPIO6).
It looks like everything should be updated to GPIO6.
Will there be other CLs for the other boards?
https://review.coreboot.org/c/coreboot/+/74512/comment/a021caa5_92cd1dd7
PS1, Line 9: SSD_AUX_RST_L(GPIO6)
nit: add a space: `SSD_AUX_RST_L (GPIO6)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79
Gerrit-Change-Number: 74512
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Tue, 18 Apr 2023 21:36:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment