Attention is currently required from: Martin Roth, Evan Green, Paul Menzel.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56046 )
Change subject: mb/google/dedede: Fix the pointer/address used in memcpy
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56046/comment/11be5849_c6876072
PS2, Line 12: memcpy. This issue is caught during coverity scan CID: 1458054, 1458053.
Please use the tag Found-by.
Done
https://review.coreboot.org/c/coreboot/+/56046/comment/dfd82bed_e98d44e1
PS2, Line 17: function.
Were there any functional issues?
Not that I am aware of since the original CL (CB:54671) landed very recently - just couple of days back. There was a refactoring in that CL where the bug got introduced.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56046
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa
Gerrit-Change-Number: 56046
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 02 Jul 2021 21:30:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment