Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Kyösti Mälkki, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51756 )
Change subject: mb/amd,google: use PAD_NF_SCI for GPIO_2 config in soc/amd based boards
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51756/comment/21b7f1ba_4d7691e6
PS1, Line 22: since S3 resume isn't working on amd/mandolin yet.
I think we should ensure that this change does not break the wake functionality as well. Can you please ensure this gets tested on a zork device if mandolin cannot be used?
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51756/comment/8be5cb05_749f090b
PS1, Line 14: , SCI
For the Google mainboards, the comment on top of the GPIO configuration refers to the netname.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic069e46b759fb6746645faccd254263c49a892d4
Gerrit-Change-Number: 51756
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 24 Mar 2021 05:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment