Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45150 )
Change subject: device: Allow configuring bus mastering for PCI bridges conditionally
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45150/3/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/45150/3/src/device/Kconfig@537
PS3, Line 537: ALLOW
well, is it really "allow"? the code reads like "set it if the Kconfig is set"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7cacce28f473dda76ca203016dbb8e00149a990
Gerrit-Change-Number: 45150
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 06:59:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment