Attention is currently required from: Patrick Rudolph, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50594 )
Change subject: src: use ARRAY_SIZE where possible
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/arch/x86/cpu.c:
https://review.coreboot.org/c/coreboot/+/50594/comment/7c19ea2f_54b4f901
PS2, Line 126: ARRAY_SIZE
It's pretty universally available through stddef.h. […]
Or just include types.h
File src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c:
https://review.coreboot.org/c/coreboot/+/50594/comment/fb1b666f_1de5f299
PS2, Line 135: int
for another patch: make this unsigned and drop the cast
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I083704fd48faeb6c67bba3367fbcfe554a9f7c66
Gerrit-Change-Number: 50594
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 15 Feb 2021 10:12:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment