Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49054 )
Change subject: drivers/intel/gma: add macro for one internal panel in gfx struct
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.h
File src/drivers/intel/gma/gma.h:
https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.h...
PS1, Line 33: at port A
PRM (Doc Ref # IHD-OS-KBL-Vol 12-1.17) / intel-gfx-prm-osrc-kbl-vol12-display.pdf : Page 108 has a table with "DDI Equivalent Names":
DDI A: Port 0, DDI-A, DDIA, Port A, DDI0, eDP
DDI B: Port 1, DDI-B, DDIB, Port B, DDI1
...
In other words, it doesn't mention ACPI?
At least i915 doesn't seem to use the field at all, cf.
`ACPI_DISPLAY_PORT_ATTACHMENT_SHIFT` etc. in
`display/intel_acpi.c`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5308b53667657d0b255ae5bc543f1a00431f5818
Gerrit-Change-Number: 49054
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Sun, 03 Jan 2021 15:16:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment