Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Martin L Roth, Maximilian Brune, Nico Huber, Patrick Rudolph, Tim Wawrzynczak.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78071?usp=email )
Change subject: acpi: Add PPTT support
......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS9:
Kconfig LGTM. […]
will do
File src/acpi/acpi_pptt.c:
https://review.coreboot.org/c/coreboot/+/78071/comment/bc524039_a4260d28 :
PS8, Line 127: setup_topology(node->sibling, parent_ref, current);
It's not only about understanding what the program is supposed to do but […]
You are right. I will replace the sibling recursion with the proposed loop :)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/78071/comment/52e7e62f_8f08cf39 :
PS9, Line 1392: /* As defined in ACPI 6.4 */
Not really a complaint about this patch, but maybe it's time to start looking at splitting up this h […]
Good suggestion. I would prefer having separate headers, but I think we should split it (along with all the other tables like hpet, ...) in another patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78071?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia119e1ba15756704668116bdbc655190ec94ff10
Gerrit-Change-Number: 78071
Gerrit-PatchSet: 9
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 02 Nov 2023 01:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: David Milosevic
David.Milosevic@9elements.com
Gerrit-MessageType: comment