Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS - coreboot-gerrit

3 May 2021


      Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Patrick Rudolph.
Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52800/comment/102d10f5_47b20bd1 
PS3, Line 7: Added CMOS option to disable ME
...
Please use a prefix, and also [use imperative mood in commit message summaries](https://chris.beams. […]
Is that okay?
Patchset:
PS4:
...
just curious, have you seen CB:37115 ?
Yup. By any chance, are you going to suggest hiding the device in the same way?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20
Gerrit-Change-Number: 52800
Gerrit-PatchSet: 4
Gerrit-Owner: Star Labs admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 May 2021 06:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment