Attention is currently required from: Sean Rhodes, Maximilian Brune, Angel Pons.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73894 )
Change subject: Revert "mb/starlabs/*: Remove sleepstates.asl"
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Tried that patch on TGL, seems to assert on: […]
Ah right, edk2 has a different patches workflow. Thanks, good to hear!
I think the variable size is another issue, SMMSTORE has a size limitation due to the communication region size, I believe? That's fixed by setting `gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8000` in UefiPayloadPkg.dsc, but it doesn't make sense to upstream it without SMMSTORE. I've squashed some SMMSTORE fixes into https://github.com/benjamindoron/edk2/commit/be6df2cebf1f572a3eeb510315815c0....
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e90266e66192b328b9af51c5e614774a248ddf0
Gerrit-Change-Number: 73894
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 15:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment