[S] Change in coreboot[main]: soc/amd: Add DBG2 ACPI table - coreboot-gerrit

1 Dec 2023


      Attention is currently required from: Cliff Huang, Felix Held, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Raul Rangel, Simon Glass, Tim Wawrzynczak, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79174?usp=email )
Change subject: soc/amd: Add DBG2 ACPI table
......................................................................
Patch Set 12:
(1 comment)
File src/soc/amd/common/block/acpi/tables.c:
https://review.coreboot.org/c/coreboot/+/79174/comment/a84a67f3_0b734b32 :
PS10, Line 15: current = acpi_16550_mmio32_write_dbg2_uart(rsdp, current,
...
Use a regular `if`, not a `#if`
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79174?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c97a78d1889549421baf0bc1a2e8f959a0f47e2
Gerrit-Change-Number: 79174
Gerrit-PatchSet: 12
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Simon Glass sjg@chromium.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 01 Dec 2023 06:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng fishbaozi@gmail.com
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment