Attention is currently required from: Hung-Te Lin, Yidi Lin.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86381?usp=email )
Change subject: mb/google/rauru: Notify EC that AP is in S0 ......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86381/comment/ff65c8b5_39cd8f9d?usp... : PS5, Line 7: Add GPIO_AP_SUSPEND_L initial setting
`S0`, not `SO`
Done
https://review.coreboot.org/c/coreboot/+/86381/comment/d220c83f_4012da8c?usp... : PS5, Line 8: : The GPIO_AP_SUSPEND_L pin is used for communication between the AP and : EC to confirm the AP's status. When the AP is running normally, it : should be high, and when the AP is in sleep mode, it should be low. This : way, the EC will know that the system is in sleep mode. Therefore, : during the initial boot phase, the GPIO_AP_SUSPEND_L pin needs to be : initialized to output high.
GPIO_AP_SUSPEND_L is supposed to be high in S0, and low in S3. […]
Done