Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 )
Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icelak...
File Documentation/mainboard/intel/icelake_rvp.md:
https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icelak...
PS2, Line 17:
"Note: Until the FSP binaries for this platform are released, you need to add them manually before building."?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d
Gerrit-Change-Number: 29828
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Nov 2018 15:41:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment